Initial version for documenting the new jobs framework #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ping @fritzmg |
fritzmg
reviewed
Sep 15, 2025
Contributor
There was a problem hiding this comment.
lgtm - however, what I am kind of missing is the intended or typical usage. You will usually have something like this, right?
// In some controller
$job = $this->jobs->createJob('data_export');
$message = new DataExportMessage($someData, $job->getUuid());
$this->messageBus->dispatch($message);// In the DataExportMessageHandler
$job = $this->jobs->getByUuid($message->getJobUuid());
$this->jobs->persist($job->markPending());
// Do some work …
$this->jobs->persist($job->markCompleted());
Member
Author
|
Yes, if you want to. Could also be a cronjob though etc., yes. |
Member
Author
|
Can we get this merged? It's still completely undocumented at the moment although this PR has been here for almost a quarter now... |
Contributor
|
I'd still prefer it if we had examples. But if neither of us has the time, I will merge it as is. |
Contributor
|
Thank you @Toflar |
Member
Author
|
It's super experimental still anyway. I think it'll make much more sense to explain it with regard to "Look at how the core does it in xy" once we use it properly ourselves which might happen in v5.7 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.